build_overrides/build.gni - Issue 1919383002: GN: Put BoringSSL Chromium specific targets inside a condition

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build_overrides/build.gni

Issue 1919383002: GN: Put BoringSSL Chromium specific targets inside a condition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comment for build_with_chromium variable Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453.	5 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453.

6 # Some WebRTC targets require the 10.7 deployment version of the Mac SDK	6 # Some WebRTC targets require the 10.7 deployment version of the Mac SDK

7 # and a 10.11 min SDK, but those targets are only used in non-Chromium	7 # and a 10.11 min SDK, but those targets are only used in non-Chromium

8 # builds. We can remove this when Chromium drops 10.6 support and also	8 # builds. We can remove this when Chromium drops 10.6 support and also

9 # requires 10.7.	9 # requires 10.7.

10 mac_sdk_min_build_override = "10.10"	10 mac_sdk_min_build_override = "10.10"

11 mac_deployment_target_build_override = "10.7"	11 mac_deployment_target_build_override = "10.7"

	12

	13 # Variable that can be used to support multiple build scenarios, like having

	14 # Chromium specific targets in a client project's GN file etc.

	15 build_with_chromium = true
	davidben 2016/04/26 21:25:16 Should this be in a boringssl.gni or maybe third_p Should this be in a boringssl.gni or maybe third_party/boringssl include webrtc.gni? I'll defer to you all since I don't know what the convention is here. Dirk Pranke 2016/04/26 21:43:22 The convention is totally made up :). I think this Show quoted text On 2016/04/26 21:25:16, davidben wrote: > Should this be in a boringssl.gni or maybe third_party/boringssl include > webrtc.gni? I'll defer to you all since I don't know what the convention is > here. The convention is totally made up :). I think this location is fine as it'll be used for variables needed across multiple repos. And, again, hopefully this all goes away soon and is replaced with something less stupid (which I can say since it's my design ;).
OLD	NEW

« no previous file with comments | « no previous file | build_overrides/webrtc.gni » ('j') | no next file with comments »