[SVG] Missing image loader update on re-insert.

[SVG] Missing image loader update on re-insert.

After r167729, SVG images are trying to minimize the number of loader
updates, only firing them on insertion when the URI changes.

But the loader may not even try to fetch the image in some cases
(inactive document for example), leaving the SVG image element in an
invalid state where it doesn't attempt to update the loader again.

The CL expands the SVGImageElement::insertedInto() logic to update the
loader in two cases:

  * dirty URI (current criterion)
  * missing image resource (which signals a failed/incomplete previous
    loader fetch)

BUG=350282
R=pdr@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168802

[pdr., 2014-03-09 00:12:40]

LGTM with a question.

https://codereview.chromium.org/191933003/diff/1/Source/core/svg/SVGImageElem...
File Source/core/svg/SVGImageElement.cpp (right):

https://codereview.chromium.org/191933003/diff/1/Source/core/svg/SVGImageElem...
Source/core/svg/SVGImageElement.cpp:214: if (!m_imageLoader.image() ||
!m_imageLoader.image()->hasImage())
The !m_imageLoader.image() check looks right to me. Is this second check for
hasImage necessary?

[f(malita), 2014-03-09 01:35:19]

Thanks.

https://codereview.chromium.org/191933003/diff/1/Source/core/svg/SVGImageElem...
File Source/core/svg/SVGImageElement.cpp (right):

https://codereview.chromium.org/191933003/diff/1/Source/core/svg/SVGImageElem...
Source/core/svg/SVGImageElement.cpp:214: if (!m_imageLoader.image() ||
!m_imageLoader.image()->hasImage())
On 2014/03/09 00:12:41, pdr wrote:
> The !m_imageLoader.image() check looks right to me. Is this second check for
> hasImage necessary?

Not for this particular failure - it's me getting paranoid and dialing it way
back :)

Let's land without.

[f(malita), 2014-03-09 01:37:11]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2014-03-09 01:37:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fmalita@chromium.org/191933003/20001

[commit-bot: I haz the power, 2014-03-09 02:46:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-09 02:46:42]

Try jobs failed on following builders: linux_blink

[f(malita), 2014-03-09 05:40:29]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2014-03-09 05:40:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fmalita@chromium.org/191933003/20001

[commit-bot: I haz the power, 2014-03-09 05:44:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-09 05:44:37]

Try jobs failed on following builders: linux_blink

[f(malita), 2014-03-09 06:01:21]

Committed patchset #2 manually as r168802 (presubmit successful).