[SVG] Missing image loader update on re-insert.

Source/core/svg/SVGImageElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Rob Buis <buis@kde.org>
  * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 190 matching lines @@
 {
     SVGGraphicsElement::insertedInto(rootParent);
     if (!rootParent->inDocument())
         return InsertionDone;
 
     // We can only resolve base URIs properly after tree insertion - hence, URI mutations while
     // detached are deferred until this point.
     if (m_needsLoaderURIUpdate) {
         m_imageLoader.updateFromElementIgnoringPreviousError();
         m_needsLoaderURIUpdate = false;
+    } else {
+        // A previous loader update may have failed to actually fetch the image if the document
+        // was inactive. In that case, force a re-update (but don't clear previous errors).
+        if (!m_imageLoader.image() || !m_imageLoader.image()->hasImage())

[pdr., 2014/03/09 00:12:41]

The !m_imageLoader.image() check looks right to me. Is this second check for
hasImage necessary?

[f(malita), 2014/03/09 01:35:20]

Not for this particular failure - it's me getting paranoid and dialing it way
back :)

Let's land without.

+            m_imageLoader.updateFromElement();
     }
 
     return InsertionDone;
 }
 
 const AtomicString SVGImageElement::imageSourceURL() const
 {
     return AtomicString(hrefString());
 }
 
 void SVGImageElement::didMoveToNewDocument(Document& oldDocument)
 {
     m_imageLoader.elementDidMoveToNewDocument();
     SVGGraphicsElement::didMoveToNewDocument(oldDocument);
 }
 
 }