Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1919283005: Eliminate calls to cricket::VideoFrame's GetNativeHandle, GetYPlane. (Closed)

Created:
4 years, 7 months ago by nisse-chromium (ooo August 14)
Modified:
4 years, 7 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate calls to cricket::VideoFrame's GetNativeHandle, GetYPlane. Instead, go via video_frame_buffer(). BUG=webrtc:5682 Committed: https://crrev.com/c84f6fc566a5205844cd2db3a04690ee9b1fd122 Cr-Commit-Position: refs/heads/master@{#390046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nisse-chromium (ooo August 14)
Needed to be able to land removal of cricket::VideoFrame::GetYPlane.
4 years, 7 months ago (2016-04-27 09:28:13 UTC) #2
perkj_chrome
lgtm
4 years, 7 months ago (2016-04-27 10:37:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919283005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919283005/1
4 years, 7 months ago (2016-04-27 10:37:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 11:28:17 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 11:29:39 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c84f6fc566a5205844cd2db3a04690ee9b1fd122
Cr-Commit-Position: refs/heads/master@{#390046}

Powered by Google App Engine
This is Rietveld 408576698