Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1919243002: Revert of Add initial implementation of GrShape and GrStyle classes and tests (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add initial implementation of GrShape and GrStyle classes and tests (patchset #11 id:280001 of https://codereview.chromium.org/1822723003/ ) Reason for revert: test failing Original issue's description: > Add initial implementation of GrShape and GrStyle classes and tests > > The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003 > > Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8 > > Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09 TBR=robertphillips@google.com,egdaniel@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/82ecc5773faa0068186557f8ab2957620a7d72ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -859 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
D src/gpu/GrShape.h View 1 chunk +0 lines, -160 lines 0 comments Download
D src/gpu/GrShape.cpp View 1 chunk +0 lines, -254 lines 0 comments Download
D src/gpu/GrStyle.h View 1 chunk +0 lines, -92 lines 0 comments Download
D src/gpu/GrStyle.cpp View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/GrShapeTest.cpp View 1 chunk +0 lines, -316 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bsalomon
Created Revert of Add initial implementation of GrShape and GrStyle classes and tests
4 years, 8 months ago (2016-04-26 15:41:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919243002/1
4 years, 8 months ago (2016-04-26 15:41:41 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 15:41:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/82ecc5773faa0068186557f8ab2957620a7d72ea

Powered by Google App Engine
This is Rietveld 408576698