chrome/browser/resources/settings/site_settings/compiled_resources2.gyp - Issue 1919183005: Cleanup: Extract icon related methods outside of util.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/compiled_resources2.gyp

Issue 1919183005: Cleanup: Extract icon related methods outside of util.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename favicon.html to icon.html Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.js ('k') | chrome/browser/resources/settings/site_settings/site_settings_behavior.html » ('j') | chrome/test/data/webui/webui_resource_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/compiled_resources2.gyp

diff --git a/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp b/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp

index 1d5b8abb09d53efdd9292648db145c6fbdbd1493..e3ff72059bf355f65087673306f99239f9438152 100644

--- a/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp

+++ b/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp

@@ -69,8 +69,8 @@

'target_name': 'site_settings_behavior',

'dependencies': [

'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert',

+ '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:icon',

'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:load_time_data',

- '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:util',

'<(EXTERNS_GYP):settings_private',

'constants',