Cleanup: Extract icon related methods outside of util.js

chrome/test/data/webui/webui_resource_browsertest.cc

Index: chrome/test/data/webui/webui_resource_browsertest.cc
diff --git a/chrome/test/data/webui/webui_resource_browsertest.cc b/chrome/test/data/webui/webui_resource_browsertest.cc
index 61c0ba8fd1848584ecae8b966237fa209e06de57..6993491c2925e182b989998d5577be5e0ab76dbe 100644
--- a/chrome/test/data/webui/webui_resource_browsertest.cc
+++ b/chrome/test/data/webui/webui_resource_browsertest.cc
@@ -236,11 +236,17 @@ IN_PROC_BROWSER_TEST_F(WebUIResourceBrowserTest, SplitterTest) {
 }
 
 IN_PROC_BROWSER_TEST_F(WebUIResourceBrowserTest, UtilTest) {

[Dan Beam, 2016/05/06 22:39:06]

doesn't this need a:

  AddLibrary(IDR_WEBUI_JS_CR);

above it like previously?

[dpapad, 2016/05/06 22:56:33]

Strictly speaking it is not needed. The non-favicon related tests of
util_test.html do not exercise any code that depends on cr.js. I had actually
added this line at
https://codereview.chromium.org/1914073005/diff/60001/chrome/test/data/webui/...,
when I added favicon related tests.

[Dan Beam, 2016/05/06 23:01:55]

Acknowledged.

-  AddLibrary(IDR_WEBUI_JS_CR);
   AddLibrary(IDR_WEBUI_JS_UTIL);
   LoadFile(base::FilePath(FILE_PATH_LITERAL("util_test.html")));
 }
 
+IN_PROC_BROWSER_TEST_F(WebUIResourceBrowserTest, IconTest) {
+  AddLibrary(IDR_WEBUI_JS_CR);
+  AddLibrary(IDR_WEBUI_JS_UTIL);
+  AddLibrary(IDR_WEBUI_JS_ICON);
+  LoadFile(base::FilePath(FILE_PATH_LITERAL("icon_test.html")));
+}
+
 IN_PROC_BROWSER_TEST_F(WebUIResourceBrowserTest, PromiseResolverTest) {
   AddLibrary(IDR_WEBUI_JS_ASSERT);
   AddLibrary(IDR_WEBUI_JS_PROMISE_RESOLVER);