chrome/browser/resources/options/home_page_overlay.js - Issue 1919183005: Cleanup: Extract icon related methods outside of util.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/home_page_overlay.js

Issue 1919183005: Cleanup: Extract icon related methods outside of util.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename favicon.html to icon.html Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/compiled_resources.gyp ('k') | chrome/browser/resources/options/manage_profile_overlay.js » ('j') | chrome/test/data/webui/webui_resource_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/home_page_overlay.js

diff --git a/chrome/browser/resources/options/home_page_overlay.js b/chrome/browser/resources/options/home_page_overlay.js

index d314fa93c3bf2ad8d336a68ea998d6d53aa657b0..4829d085ebb0f83cb5d0b11c48b1c09d6b8c6ee5 100644

--- a/chrome/browser/resources/options/home_page_overlay.js

+++ b/chrome/browser/resources/options/home_page_overlay.js

@@ -92,7 +92,8 @@ cr.define('options', function() {

updateFavicon_: function() {

var urlField = $('homepage-url-field');

- urlField.style.backgroundImage = getFaviconImageSet(urlField.value);

+ urlField.style.backgroundImage = cr.icon.getFaviconImageSet(

+ urlField.value);

/**