chrome/browser/resources/history/other_devices.js - Issue 1919183005: Cleanup: Extract icon related methods outside of util.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/history/other_devices.js

Issue 1919183005: Cleanup: Extract icon related methods outside of util.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename favicon.html to icon.html Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/history/history.js ('k') | chrome/browser/resources/md_history/compiled_resources2.gyp » ('j') | chrome/test/data/webui/webui_resource_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/history/other_devices.js

diff --git a/chrome/browser/resources/history/other_devices.js b/chrome/browser/resources/history/other_devices.js

index 8f46192d61f9a8a62b9171c7ab579c3410fbc6a7..6dca06be86f4d3f6ac8a8e45da522f9a82b45ed7 100644

--- a/chrome/browser/resources/history/other_devices.js

+++ b/chrome/browser/resources/history/other_devices.js

@@ -263,7 +263,7 @@ Device.prototype.createSessionContents_ = function(maxNumTabs) {

numTabsShown++;

var a = createElementWithClassName('a', 'device-tab-entry');

a.href = tab.url;

- a.style.backgroundImage = getFaviconImageSet(tab.url);

+ a.style.backgroundImage = cr.icon.getFaviconImageSet(tab.url);

this.addHighlightedText_(a, tab.title);

// Add a tooltip, since it might be ellipsized. The ones that are not

// necessary will be removed once added to the document, so we can