Use static dispatch for dynamic on Object methods

Use static dispatch for dynamic on Object methods

Fixes #510

R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/2574c5d559cd5125820166ff8f9ba52f78445512

[Harry Terkelsen, 2016-04-26 20:47:43]

het@google.com changed reviewers:
+ jmesserly@google.com, vsm@google.com

[Harry Terkelsen, 2016-04-26 20:51:55]

https://codereview.chromium.org/1919173004/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1919173004/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:3133: var type = target.propagatedType ??
getStaticType(target);
btw, this is the only use of propagatedType in ddc... I wasn't sure if the
analyzer API changed and getStaticType should give propagatedType if it is set
or if there was a reason not to use it?

[Jennifer Messerly, 2016-04-26 21:04:56]

Nice find!

https://codereview.chromium.org/1919173004/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1919173004/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:3133: var type = target.propagatedType ??
getStaticType(target);
On 2016/04/26 20:51:55, Harry Terkelsen wrote:
> btw, this is the only use of propagatedType in ddc... I wasn't sure if the
> analyzer API changed and getStaticType should give propagatedType if it is set
> or if there was a reason not to use it?

yeah we never to use it. It's the old Analyzer inference, it's unsound and it's
also something we hope to remove from Strong Mode Analyzer in the near future
(we waste time in some cases inferring things twice, the old way and the new
way).

... so I don't think this is the right fix, but it's a great find :). So what
this means is old-Analyzer inferred something different than new-Strong-Mode
did. We should have a look into the example and the Analyzer code and figure out
why this happened & fix it over there.

This is the function that's supposed to be inferring the correct type for us:
https://github.com/dart-lang/sdk/blob/2bd7317edee49e5365e593e22dee52d95ed7356...

Maybe the logic got broken somehow, but it used to work.

[Harry Terkelsen, 2016-04-27 00:47:51]

Description was changed from

==========
use propagatedType when deciding if static dispatch is required

Fixes #510
==========

to

==========
Use static dispatch for dynamic on Object methods

Fixes #510
==========

[Jennifer Messerly, 2016-04-27 00:52:31]

LGTM!

[Harry Terkelsen, 2016-04-27 00:54:07]

Description was changed from

==========
Use static dispatch for dynamic on Object methods

Fixes #510
==========

to

==========
Use static dispatch for dynamic on Object methods

Fixes #510

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/2574c5d559cd5125820166ff8f9b...
==========

[Harry Terkelsen, 2016-04-27 00:54:08]

Committed patchset #2 (id:20001) manually as
2574c5d559cd5125820166ff8f9ba52f78445512 (presubmit successful).