Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: lib/src/compiler/code_generator.dart

Issue 1919173004: Use static dispatch for dynamic on Object methods (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/codegen/expect/language-all.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/compiler/code_generator.dart
diff --git a/lib/src/compiler/code_generator.dart b/lib/src/compiler/code_generator.dart
index 43de895f24bd03427106230beb2078f5d600b6e6..b17ee5b5a1ab26de6a1b68dbffc7b3ce6761d9a8 100644
--- a/lib/src/compiler/code_generator.dart
+++ b/lib/src/compiler/code_generator.dart
@@ -3139,6 +3139,7 @@ class CodeGenerator extends GeneralizingAstVisitor
// If the target may be an extension type, we also use static dispatch
// as we don't symbolize object properties like hashCode.
return isNullable(target) ||
+ type.isDynamic ||
(_extensionTypes.contains(type.element) && target is! SuperExpression);
}
« no previous file with comments | « no previous file | test/codegen/expect/language-all.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698