third_party/WebKit/Source/web/GeolocationClientProxy.cpp - Issue 1919153002: Tidy up WebGeolocationController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/GeolocationClientProxy.cpp

Issue 1919153002: Tidy up WebGeolocationController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: still support implicit conversion Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/GeolocationClientProxy.cpp

diff --git a/third_party/WebKit/Source/web/GeolocationClientProxy.cpp b/third_party/WebKit/Source/web/GeolocationClientProxy.cpp

index 23a9d65a2fc3293f42d85c9955512b5747f2fa82..004cf4c5c4615eecbb8b85be0a01f6b68a41b561 100644

--- a/third_party/WebKit/Source/web/GeolocationClientProxy.cpp

+++ b/third_party/WebKit/Source/web/GeolocationClientProxy.cpp

@@ -74,7 +74,7 @@ GeolocationPosition* GeolocationClientProxy::lastPosition()

else

m_lastPosition.clear();

- return m_lastPosition.get();

+ return m_lastPosition;

}

void GeolocationClientProxy::requestPermission(Geolocation* geolocation)