pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart - Issue 1919143002: Store constant variable initializers in elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart

Issue 1919143002: Store constant variable initializers in elements. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart

diff --git a/pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart b/pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart

index bc1de29230a783a1efc8d9e199a0037f40137d7b..fa01ef9b1c5599180ead103680b9dab7330b1dd3 100644

--- a/pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart

+++ b/pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart

@@ -98,7 +98,7 @@ class ParameterStubGenerator {

parametersBuffer[optionalParameterStart + index] =

new jsAst.Parameter(jsName);

} else {

- ConstantValue value = handler.getConstantValueForVariable(element);

+ ConstantValue value = handler.getConstantValue(element.constant);

if (value == null) {

argumentsBuffer[count] =

emitter.constantReference(new NullConstantValue());