|
|
Created:
6 years, 9 months ago by kouhei (in TOK) Modified:
6 years, 9 months ago CC:
blink-reviews, krit, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis Base URL:
svn://svn.chromium.org/blink/trunk Visibility:
Public. |
DescriptionFix SVGImageChromeClient::scheduleAnimation() crash.
|SVGImageChromeClient::scheduleAnimation()| can be called without valid |m_image| since r168612.
The CL adds null check before proceeding.
TESTS=svg/as-image/*.html
BUG=350907
Patch Set 1 #
Messages
Total messages: 25 (0 generated)
LGTM > TESTS=svg/as-image/*.html Was the tests crashing? Otherwise you want to add a new test that covers the change in this CL.
On 2014/03/10 06:23:19, haraken wrote: > LGTM > > > TESTS=svg/as-image/*.html > > Was the tests crashing? Otherwise you want to add a new test that covers the > change in this CL. Yes, they were crashing locally (w/ enable_oilpan), but this is hard to repro consistently as it depends on gc timing.
The CQ bit was checked by kouhei@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/191913004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_blink_rel
Thanks for fixing!
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/191913004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/191913004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_blink_rel
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/191913004/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/191913004/1
How do we test this?
This can't be oilpan only, since Karen says she has reports of this from the wild. When I search the crash db, I only see 8 reports total though. :(
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
Landed this in https://codereview.chromium.org/193323003. I don't like the patch w/o a test, but karen believes this is blocking her ability to roll dev-channel so taking the pragmatic approach to give folks more connected to this issue time to sort out the right approach.
On 2014/03/10 22:05:47, eseidel wrote: > Landed this in https://codereview.chromium.org/193323003. I don't like the > patch w/o a test, but karen believes this is blocking her ability to roll > dev-channel so taking the pragmatic approach to give folks more connected to > this issue time to sort out the right approach. Actually this does crash in non-oilpan builds on TESTS=svg/as-image/*.html . However I couldn't find a way to consistently repro this. |