Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1919103002: [mojo-edk] Fix some multiprocess test expectations (Closed)

Created:
4 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@flake
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Fix some multiprocess test expectations Some of the shared buffer tests were waiting for child processes to respond to "quit" messages with an "ok" before exiting, but delivery of that message can race with child process exit, leading to MojoWait failures. This extra synchronization step is unnecessary, so this CL removes it. BUG=603280 R=amistry@chromium.org Committed: https://crrev.com/d582e6542b8e590ffbfcaf0b2a21afc83b2166d8 Cr-Commit-Position: refs/heads/master@{#389695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M mojo/edk/system/shared_buffer_unittest.cc View 6 chunks +0 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
Ken Rockot(use gerrit already)
An easy one
4 years, 8 months ago (2016-04-26 01:27:56 UTC) #1
Anand Mistry (off Chromium)
lgtm
4 years, 8 months ago (2016-04-26 03:36:24 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 1914053003 Patch 1). Please resolve the dependency and ...
4 years, 8 months ago (2016-04-26 03:37:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919103002/1
4 years, 8 months ago (2016-04-26 04:27:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 04:32:07 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 04:34:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d582e6542b8e590ffbfcaf0b2a21afc83b2166d8
Cr-Commit-Position: refs/heads/master@{#389695}

Powered by Google App Engine
This is Rietveld 408576698