Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: mojo/edk/system/shared_buffer_unittest.cc

Issue 1919103002: [mojo-edk] Fix some multiprocess test expectations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@flake
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/shared_buffer_unittest.cc
diff --git a/mojo/edk/system/shared_buffer_unittest.cc b/mojo/edk/system/shared_buffer_unittest.cc
index 7f7d80e910481cc85bc3f2f5d84553b7614b553c..bdead31d02b3c5b888003c74f654ba97b690081b 100644
--- a/mojo/edk/system/shared_buffer_unittest.cc
+++ b/mojo/edk/system/shared_buffer_unittest.cc
@@ -126,7 +126,6 @@ DEFINE_TEST_CLIENT_TEST_WITH_PIPE(CreateAndPassBuffer, SharedBufferTest, h) {
WriteMessageWithHandles(other_child, "", &dupe, 1);
EXPECT_EQ("quit", ReadMessage(h));
- WriteMessage(h, "ok");
}
DEFINE_TEST_CLIENT_TEST_WITH_PIPE(ReceiveAndEditBuffer, SharedBufferTest, h) {
@@ -143,7 +142,6 @@ DEFINE_TEST_CLIENT_TEST_WITH_PIPE(ReceiveAndEditBuffer, SharedBufferTest, h) {
WriteToBuffer(b, 0, message);
EXPECT_EQ(MOJO_RESULT_OK, MojoClose(b));
EXPECT_EQ("quit", ReadMessage(h));
- WriteMessage(h, "ok");
}
#if defined(OS_ANDROID)
@@ -171,10 +169,8 @@ TEST_F(SharedBufferTest, MAYBE_PassSharedBufferFromChildToChild) {
ReadMessageWithHandles(h0, &b, 1);
WriteMessage(h1, "quit");
- EXPECT_EQ("ok", ReadMessage(h1));
END_CHILD()
WriteMessage(h0, "quit");
- EXPECT_EQ("ok", ReadMessage(h0));
END_CHILD()
// The second child should have written this message.
@@ -197,8 +193,6 @@ DEFINE_TEST_CLIENT_TEST_WITH_PIPE(CreateAndPassBufferParent, SharedBufferTest,
EXPECT_EQ("quit", ReadMessage(parent));
WriteMessage(child, "quit");
- EXPECT_EQ("ok", ReadMessage(child));
- WriteMessage(parent, "ok");
END_CHILD()
}
@@ -212,8 +206,6 @@ DEFINE_TEST_CLIENT_TEST_WITH_PIPE(ReceiveAndEditBufferParent, SharedBufferTest,
EXPECT_EQ("quit", ReadMessage(parent));
WriteMessage(child, "quit");
- EXPECT_EQ("ok", ReadMessage(child));
- WriteMessage(parent, "ok");
END_CHILD()
}
@@ -245,10 +237,8 @@ TEST_F(SharedBufferTest, MAYBE_PassHandleBetweenCousins) {
ReadMessageWithHandles(child1, &b, 1);
WriteMessage(child2, "quit");
- EXPECT_EQ("ok", ReadMessage(child2));
END_CHILD()
WriteMessage(child1, "quit");
- EXPECT_EQ("ok", ReadMessage(child1));
END_CHILD()
// The second grandchild should have written this message.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698