Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1918793004: MacViews: add extension install dialog to MacViewsWebUIDialogs (Closed)

Created:
4 years, 8 months ago by Elly Fong-Jones
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: add extension install dialog to MacViewsWebUIDialogs This dialog is now behind the MacViewsWebUIDialogs feature flag. BUG=605657 Committed: https://crrev.com/145ffb972813fef174d6a96f2ca97983ede90c8a Cr-Commit-Position: refs/heads/master@{#389779}

Patch Set 1 #

Patch Set 2 : fix gn build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M chrome/browser/extensions/extension_install_prompt.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
Elly Fong-Jones
sky: ptal? this CL touches a few subdirectories of chrome/browser :)
4 years, 8 months ago (2016-04-25 18:42:31 UTC) #3
sky
LGTM
4 years, 8 months ago (2016-04-25 20:59:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918793004/1
4 years, 8 months ago (2016-04-26 13:31:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/218849)
4 years, 8 months ago (2016-04-26 13:49:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918793004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918793004/20001
4 years, 8 months ago (2016-04-26 14:04:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 14:57:05 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/145ffb972813fef174d6a96f2ca97983ede90c8a Cr-Commit-Position: refs/heads/master@{#389779}
4 years, 8 months ago (2016-04-26 14:59:22 UTC) #15
Elly Fong-Jones
4 years, 7 months ago (2016-04-28 15:12:53 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1926023003/ by ellyjones@chromium.org.

The reason for reverting is: Breaks mac_views_browser=1 build..

Powered by Google App Engine
This is Rietveld 408576698