Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5208)

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 1918793004: MacViews: add extension install dialog to MacViewsWebUIDialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix gn build Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
index c9c9ce00cbc558f9b95b4ce06a21fcc3cd857a12..890a3cb55ab9b12fa59fedfabb19798f70cb5893 100644
--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
@@ -771,8 +771,19 @@ void ExpandableContainerView::UpdateArrowToggle(bool expanded) {
arrow_toggle_->SetImage(views::Button::STATE_NORMAL, &icon);
}
+// On Mac, GetViewsShowDialogCallback is defined in Cocoa code.
+#if !defined(OS_MACOSX)
// static
ExtensionInstallPrompt::ShowDialogCallback
ExtensionInstallPrompt::GetDefaultShowDialogCallback() {
return base::Bind(&ShowExtensionInstallDialogImpl);
}
+#endif
+
+#if defined(OS_MACOSX)
+// static
+ExtensionInstallPrompt::ShowDialogCallback
+ExtensionInstallPrompt::GetViewsShowDialogCallback() {
+ return base::Bind(&ShowExtensionInstallDialogImpl);
+}
+#endif
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698