Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1918543002: Update PaintLayer::needsPaintPhase flags when layer self-painting status changes (Closed)

Created:
4 years, 8 months ago by Xianzhu
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Update PaintLayer::needsPaintPhase flags when layer self-painting status changes This had been included in https://codereview.chromium.org/1862313002/ before I removed it thinking that self-painting status should cause layout and paint invalidation. However, bug 604351 is a case that self-painting status change doesn't cause layout and paint invalidation. BUG=604351 TEST=PaintLayerPainterTest.PaintPhasesUpdateOnBecomingSelfPainting TEST=PaintLayerPainterTest.PaintPhasesUpdateOnBecomingNonSelfPainting Review URL: https://codereview.chromium.org/1900263002 Cr-Commit-Position: refs/heads/master@{#388880} Committed: https://chromium.googlesource.com/chromium/src/+/f984c3395c994122091f7e7db88c8776f51f9b0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -2 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Xianzhu
4 years, 8 months ago (2016-04-22 21:43:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f984c3395c994122091f7e7db88c8776f51f9b0e.

Powered by Google App Engine
This is Rietveld 408576698