Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 1918543002: Update PaintLayer::needsPaintPhase flags when layer self-painting status changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 2442 matching lines...) Expand 10 before | Expand all | Expand 10 after
2453 } 2453 }
2454 2454
2455 void PaintLayer::updateSelfPaintingLayer() 2455 void PaintLayer::updateSelfPaintingLayer()
2456 { 2456 {
2457 bool isSelfPaintingLayer = shouldBeSelfPaintingLayer(); 2457 bool isSelfPaintingLayer = shouldBeSelfPaintingLayer();
2458 if (this->isSelfPaintingLayer() == isSelfPaintingLayer) 2458 if (this->isSelfPaintingLayer() == isSelfPaintingLayer)
2459 return; 2459 return;
2460 2460
2461 m_isSelfPaintingLayer = isSelfPaintingLayer; 2461 m_isSelfPaintingLayer = isSelfPaintingLayer;
2462 2462
2463 if (parent()) 2463 if (PaintLayer* parent = this->parent()) {
2464 parent()->dirtyAncestorChainHasSelfPaintingLayerDescendantStatus(); 2464 parent->dirtyAncestorChainHasSelfPaintingLayerDescendantStatus();
2465
2466 if (PaintLayer* enclosingSelfPaintingLayer = parent->enclosingSelfPainti ngLayer()) {
2467 if (isSelfPaintingLayer)
2468 mergeNeedsPaintPhaseFlagsFrom(*enclosingSelfPaintingLayer);
2469 else
2470 enclosingSelfPaintingLayer->mergeNeedsPaintPhaseFlagsFrom(*this) ;
2471 }
2472 }
2465 } 2473 }
2466 2474
2467 PaintLayer* PaintLayer::enclosingSelfPaintingLayer() 2475 PaintLayer* PaintLayer::enclosingSelfPaintingLayer()
2468 { 2476 {
2469 PaintLayer* layer = this; 2477 PaintLayer* layer = this;
2470 while (layer && !layer->isSelfPaintingLayer()) 2478 while (layer && !layer->isSelfPaintingLayer())
2471 layer = layer->parent(); 2479 layer = layer->parent();
2472 return layer; 2480 return layer;
2473 } 2481 }
2474 2482
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
2905 2913
2906 void showLayerTree(const blink::LayoutObject* layoutObject) 2914 void showLayerTree(const blink::LayoutObject* layoutObject)
2907 { 2915 {
2908 if (!layoutObject) { 2916 if (!layoutObject) {
2909 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n"); 2917 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n");
2910 return; 2918 return;
2911 } 2919 }
2912 showLayerTree(layoutObject->enclosingLayer()); 2920 showLayerTree(layoutObject->enclosingLayer());
2913 } 2921 }
2914 #endif 2922 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698