Issue 1918453002: Version 5.0.71.35 (cherry-pick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1918453002: Version 5.0.71.35 (cherry-pick) (Closed)

Created:
4 years, 8 months ago by ofrobots

Modified:
4 years, 8 months ago

Reviewers:
Hannes Payer (out of office), Michael Hablich

CC:
Hannes Payer (out of office), Paweł Hajdan Jr., ulan, v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@5.0

Target Ref:
refs/pending/branch-heads/5.0

Project:
v8

Visibility:
Public.

Version 5.0.71.35 (cherry-pick) Merged 2837cb387 disallow left-trim fast path when sampling heap profiler is active R=hablich@chromium.org, hpayer@chromium.org BUG=v8:4937 Committed: https://chromium.googlesource.com/v8/v8/+/c1d51c7cf66e20506127723ab805433e0c6b5be5

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -1 line)			Patch
M	include/v8-version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap/heap.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/profiler/heap-profiler.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1 chunk	+25 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Michael Hablich

On 2016/04/22 18:08:31, ofrobots wrote: rubberstamp lgtm, please wait for hpayer's lgtm before landing.

4 years, 8 months ago (2016-04-22 18:11:38 UTC) #2

ofrobots

4 years, 8 months ago (2016-04-25 14:43:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c1d51c7cf66e20506127723ab805433e0c6b5be5.