Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1918383002: Do not penalize performance when --harmony-species is off (Closed)

Created:
4 years, 8 months ago by Dan Ehrenberg
Modified:
4 years, 7 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not penalize performance when --harmony-species is off This patch ensures that the species protector does not cause any slow paths to be taken when --harmony-species is off by refraining from writing to and reading from the protector when the flag is off. BUG=chromium:606207 R=adamk LOG=Y Committed: https://crrev.com/b1ec4cb67b7cc41be487b6780fb5c5058901ff9a Cr-Commit-Position: refs/heads/master@{#35800}

Patch Set 1 #

Patch Set 2 : also don't write to it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/isolate.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918383002/1
4 years, 8 months ago (2016-04-26 18:33:57 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918383002/20001
4 years, 8 months ago (2016-04-26 18:38:37 UTC) #5
Dan Ehrenberg
4 years, 7 months ago (2016-04-26 18:55:15 UTC) #6
adamk
lgtm
4 years, 7 months ago (2016-04-26 19:01:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918383002/20001
4 years, 7 months ago (2016-04-26 19:09:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-26 19:11:50 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 19:12:44 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b1ec4cb67b7cc41be487b6780fb5c5058901ff9a
Cr-Commit-Position: refs/heads/master@{#35800}

Powered by Google App Engine
This is Rietveld 408576698