Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: src/isolate.cc

Issue 1918383002: Do not penalize performance when --harmony-species is off (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: also don't write to it Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index c81afcc0e744226b626a9ba497af6199aa6ec5ef..fe42e162177f5574120b85243486f0d865fef11f 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2546,6 +2546,7 @@ bool Isolate::IsFastArrayConstructorPrototypeChainIntact() {
}
bool Isolate::IsArraySpeciesLookupChainIntact() {
+ if (!FLAG_harmony_species) return true;
// Note: It would be nice to have debug checks to make sure that the
// species protector is accurate, but this would be hard to do for most of
// what the protector stands for:
@@ -2564,6 +2565,7 @@ bool Isolate::IsArraySpeciesLookupChainIntact() {
}
void Isolate::InvalidateArraySpeciesProtector() {
+ if (!FLAG_harmony_species) return;
DCHECK(factory()->species_protector()->value()->IsSmi());
DCHECK(IsArraySpeciesLookupChainIntact());
PropertyCell::SetValueWithInvalidation(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698