Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 1918373002: Metrics for document.write script blocking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Bryan's comment: Returning disallowFetch from shouldDisallowFetchForMainFrameScript Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
index 0b8dee94c0573d3a26853bec968177f28b569e6c..711d340d1e3dcb71ca2df96639dce116b808a824 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
@@ -97,4 +97,96 @@ IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, NoDocumentWrite) {
embedded_test_server()->GetURL("/title2.html"));
histogram_tester_.ExpectTotalCount(
internal::kHistogramDocWriteParseStartToFirstContentfulPaint, 0);
+ histogram_tester_.ExpectTotalCount(
+ internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
+}
+
+IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
+ DocumentWriteBlock) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
+ ui_test_utils::NavigateToURL(
+ browser(), embedded_test_server()->GetURL(
+ "/page_load_metrics/document_write_script_block.html"));
+
+ ui_test_utils::NavigateToURL(browser(),
+ embedded_test_server()->GetURL("/title2.html"));
+
+ histogram_tester_.ExpectTotalCount(
+ internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 1);
+}
+
+IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
+ DocumentWriteReload) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
+ ui_test_utils::NavigateToURL(
+ browser(), embedded_test_server()->GetURL(
+ "/page_load_metrics/document_write_script_block.html"));
+
+ // Reload should not log the histogram as the script is not blocked.
+ ui_test_utils::NavigateToURL(
+ browser(), embedded_test_server()->GetURL(
+ "/page_load_metrics/document_write_script_block.html"));
+
+ ui_test_utils::NavigateToURL(
+ browser(), embedded_test_server()->GetURL(
+ "/page_load_metrics/document_write_script_block.html"));
+
+ histogram_tester_.ExpectTotalCount(
+ internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 1);
+
+ histogram_tester_.ExpectTotalCount(
+ internal::kHistogramDocWriteBlockReloadCount, 1);
+
+ ui_test_utils::NavigateToURL(browser(),
+ embedded_test_server()->GetURL("/title2.html"));
+
+ histogram_tester_.ExpectTotalCount(
+ internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 1);
+
+ histogram_tester_.ExpectTotalCount(
+ internal::kHistogramDocWriteBlockReloadCount, 2);
+}
+
+IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
+ DocumentWriteASync) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
+ ui_test_utils::NavigateToURL(
+ browser(), embedded_test_server()->GetURL(
+ "/page_load_metrics/document_write_script_async.html"));
+ ui_test_utils::NavigateToURL(browser(),
+ embedded_test_server()->GetURL("/title2.html"));
+
+ histogram_tester_.ExpectTotalCount(
+ internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
+}
+
+IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
+ DocumentWriteSameDomain) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
+ ui_test_utils::NavigateToURL(
+ browser(), embedded_test_server()->GetURL(
+ "/page_load_metrics/document_write_external_script.html"));
+ ui_test_utils::NavigateToURL(browser(),
+ embedded_test_server()->GetURL("/title2.html"));
+
+ histogram_tester_.ExpectTotalCount(
+ internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
+}
+
+IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
+ NoDocumentWriteScript) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
+ ui_test_utils::NavigateToURL(
+ browser(), embedded_test_server()->GetURL(
+ "/page_load_metrics/document_write_no_script.html"));
+ ui_test_utils::NavigateToURL(browser(),
+ embedded_test_server()->GetURL("/title2.html"));
+
+ histogram_tester_.ExpectTotalCount(
+ internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
}

Powered by Google App Engine
This is Rietveld 408576698