Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 1918373002: Metrics for document.write script blocking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Bryan's comment: Returning disallowFetch from shouldDisallowFetchForMainFrameScript Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/test/histogram_tester.h" 6 #include "base/test/histogram_tester.h"
7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h" 8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
9 #include "chrome/test/base/in_process_browser_test.h" 9 #include "chrome/test/base/in_process_browser_test.h"
10 #include "chrome/test/base/ui_test_utils.h" 10 #include "chrome/test/base/ui_test_utils.h"
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 90
91 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, NoDocumentWrite) { 91 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, NoDocumentWrite) {
92 ASSERT_TRUE(embedded_test_server()->Start()); 92 ASSERT_TRUE(embedded_test_server()->Start());
93 93
94 ui_test_utils::NavigateToURL(browser(), 94 ui_test_utils::NavigateToURL(browser(),
95 embedded_test_server()->GetURL("/title1.html")); 95 embedded_test_server()->GetURL("/title1.html"));
96 ui_test_utils::NavigateToURL(browser(), 96 ui_test_utils::NavigateToURL(browser(),
97 embedded_test_server()->GetURL("/title2.html")); 97 embedded_test_server()->GetURL("/title2.html"));
98 histogram_tester_.ExpectTotalCount( 98 histogram_tester_.ExpectTotalCount(
99 internal::kHistogramDocWriteParseStartToFirstContentfulPaint, 0); 99 internal::kHistogramDocWriteParseStartToFirstContentfulPaint, 0);
100 histogram_tester_.ExpectTotalCount(
101 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
100 } 102 }
103
104 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
105 DocumentWriteBlock) {
106 ASSERT_TRUE(embedded_test_server()->Start());
107
108 ui_test_utils::NavigateToURL(
109 browser(), embedded_test_server()->GetURL(
110 "/page_load_metrics/document_write_script_block.html"));
111
112 ui_test_utils::NavigateToURL(browser(),
113 embedded_test_server()->GetURL("/title2.html"));
114
115 histogram_tester_.ExpectTotalCount(
116 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 1);
117 }
118
119 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
120 DocumentWriteReload) {
121 ASSERT_TRUE(embedded_test_server()->Start());
122
123 ui_test_utils::NavigateToURL(
124 browser(), embedded_test_server()->GetURL(
125 "/page_load_metrics/document_write_script_block.html"));
126
127 // Reload should not log the histogram as the script is not blocked.
128 ui_test_utils::NavigateToURL(
129 browser(), embedded_test_server()->GetURL(
130 "/page_load_metrics/document_write_script_block.html"));
131
132 ui_test_utils::NavigateToURL(
133 browser(), embedded_test_server()->GetURL(
134 "/page_load_metrics/document_write_script_block.html"));
135
136 histogram_tester_.ExpectTotalCount(
137 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 1);
138
139 histogram_tester_.ExpectTotalCount(
140 internal::kHistogramDocWriteBlockReloadCount, 1);
141
142 ui_test_utils::NavigateToURL(browser(),
143 embedded_test_server()->GetURL("/title2.html"));
144
145 histogram_tester_.ExpectTotalCount(
146 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 1);
147
148 histogram_tester_.ExpectTotalCount(
149 internal::kHistogramDocWriteBlockReloadCount, 2);
150 }
151
152 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
153 DocumentWriteASync) {
154 ASSERT_TRUE(embedded_test_server()->Start());
155
156 ui_test_utils::NavigateToURL(
157 browser(), embedded_test_server()->GetURL(
158 "/page_load_metrics/document_write_script_async.html"));
159 ui_test_utils::NavigateToURL(browser(),
160 embedded_test_server()->GetURL("/title2.html"));
161
162 histogram_tester_.ExpectTotalCount(
163 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
164 }
165
166 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
167 DocumentWriteSameDomain) {
168 ASSERT_TRUE(embedded_test_server()->Start());
169
170 ui_test_utils::NavigateToURL(
171 browser(), embedded_test_server()->GetURL(
172 "/page_load_metrics/document_write_external_script.html"));
173 ui_test_utils::NavigateToURL(browser(),
174 embedded_test_server()->GetURL("/title2.html"));
175
176 histogram_tester_.ExpectTotalCount(
177 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
178 }
179
180 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
181 NoDocumentWriteScript) {
182 ASSERT_TRUE(embedded_test_server()->Start());
183
184 ui_test_utils::NavigateToURL(
185 browser(), embedded_test_server()->GetURL(
186 "/page_load_metrics/document_write_no_script.html"));
187 ui_test_utils::NavigateToURL(browser(),
188 embedded_test_server()->GetURL("/title2.html"));
189
190 histogram_tester_.ExpectTotalCount(
191 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
192 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698