runtime/vm/dart_api_impl.cc - Issue 1918313003: Split Snapshot::kFull into kCore, kAppWithJIT, and kAppNoJIT. Remove snapshot_code flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1918313003: Split Snapshot::kFull into kCore, kAppWithJIT, and kAppNoJIT. Remove snapshot_code flag. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: sync Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index c0a2fc54d11864c4b2a954a095feeef798fe84be..9dcaa4b3fee1d0dea533754dbcc75454e53ea837 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -1493,11 +1493,11 @@ DART_EXPORT Dart_Handle Dart_CreateSnapshot(

I->heap()->IterateObjects(&check_canonical);

#endif // #if defined(DEBUG).

- FullSnapshotWriter writer(vm_isolate_snapshot_buffer,

+ FullSnapshotWriter writer(Snapshot::kCore,

+ vm_isolate_snapshot_buffer,

isolate_snapshot_buffer,

ApiReallocate,

NULL, /* instructions_writer */

- false, /* snapshot_code */

true /* vm_isolate_is_symbolic */);

writer.WriteFullSnapshot();

*vm_isolate_snapshot_size = writer.VmIsolateSnapshotSize();

« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/object_store.h » ('j') | no next file with comments »