Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: runtime/vm/dart.cc

Issue 1918313003: Split Snapshot::kFull into kCore, kAppWithJIT, and kAppNoJIT. Remove snapshot_code flag. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: sync Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/benchmark_test.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart.cc
diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc
index d005ceee306f93553e07c9bde4dc37c532fddac2..3fe6df5cda0cc960acdb31db3bb88f4ab9499b54 100644
--- a/runtime/vm/dart.cc
+++ b/runtime/vm/dart.cc
@@ -214,8 +214,9 @@ const char* Dart::InitOnce(const uint8_t* vm_isolate_snapshot,
if (snapshot == NULL) {
return "Invalid vm isolate snapshot seen.";
}
- ASSERT(snapshot->kind() == Snapshot::kFull);
- VmIsolateSnapshotReader reader(snapshot->content(),
+ ASSERT(Snapshot::IsFull(snapshot->kind()));
+ VmIsolateSnapshotReader reader(snapshot->kind(),
+ snapshot->content(),
snapshot->length(),
instructions_snapshot,
data_snapshot,
@@ -482,11 +483,12 @@ RawError* Dart::InitializeIsolate(const uint8_t* snapshot_buffer, void* data) {
String::New("Invalid snapshot."));
return ApiError::New(message);
}
- ASSERT(snapshot->kind() == Snapshot::kFull);
+ ASSERT(Snapshot::IsFull(snapshot->kind()));
if (FLAG_trace_isolates) {
OS::Print("Size of isolate snapshot = %" Pd "\n", snapshot->length());
}
- IsolateSnapshotReader reader(snapshot->content(),
+ IsolateSnapshotReader reader(snapshot->kind(),
+ snapshot->content(),
snapshot->length(),
Dart::instructions_snapshot_buffer(),
Dart::data_snapshot_buffer(),
« no previous file with comments | « runtime/vm/benchmark_test.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698