Split Snapshot::kFull into kCore, kAppWithJIT, and kAppNoJIT. Remove snapshot_code flag.

Split Snapshot::kFull into kCore, kAppWithJIT, and kAppNoJIT. Remove snapshot_code flag.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/f55c9c54a8821d9a421a64810e770beb491f754d

[rmacnak, 2016-04-26 17:28:05]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-04-26 22:27:48]

lgtm

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/object_store.h
File runtime/vm/object_store.h (right):

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/object_store...
runtime/vm/object_store.h:582: return
reinterpret_cast<RawObject**>(&megamorphic_miss_function_);
return to();

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/raw_object_s...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:870: : field.raw()->to();
Why not add a to_snapshot(kind) function here to for consistency?

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:1293: : to();
Why did you not add a to_snapshot(kind) function for this similar to how it was
done for others?

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:2024: : to();
Ditto comment about to_snapshot(kind);

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/snapshot.h
File runtime/vm/snapshot.h (right):

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/snapshot.h#n...
runtime/vm/snapshot.h:157: // functions, crossing optimiziation threshold, or
deopt).
not sure I understand the comment "missing code for some funcitons, crossing
optimization threshold, or deopt"

[siva, 2016-04-26 22:27:49]

lgtm

[rmacnak, 2016-04-26 23:38:23]

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/object_store.h
File runtime/vm/object_store.h (right):

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/object_store...
runtime/vm/object_store.h:582: return
reinterpret_cast<RawObject**>(&megamorphic_miss_function_);
On 2016/04/26 22:27:47, siva wrote:
> return to();

Done.

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/raw_object_s...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:870: : field.raw()->to();
On 2016/04/26 22:27:47, siva wrote:
> Why not add a to_snapshot(kind) function here to for consistency?

Done.

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:1293: : to();
On 2016/04/26 22:27:47, siva wrote:
> Why did you not add a to_snapshot(kind) function for this similar to how it
was
> done for others?

Done.

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:2024: : to();
On 2016/04/26 22:27:47, siva wrote:
> Ditto comment about to_snapshot(kind);

Done.

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/snapshot.h
File runtime/vm/snapshot.h (right):

https://codereview.chromium.org/1918313003/diff/20001/runtime/vm/snapshot.h#n...
runtime/vm/snapshot.h:157: // functions, crossing optimiziation threshold, or
deopt).
On 2016/04/26 22:27:47, siva wrote:
> not sure I understand the comment "missing code for some funcitons, crossing
> optimization threshold, or deopt"

I mean a VM that has loaded a kAppWithJIT snapshot will still run the compiler
for all the reasons we run it when the VM loads from source.

Changed to:

    kAppWithJIT,  // Full snapshot of core libraries and application. Has some
                  // code, but may compile in the future because we haven't
                  // necessarily included code for every function or to
                  // (de)optimize.

[rmacnak, 2016-04-27 00:03:27]

Description was changed from

==========
Split Snapshot::kFull into kCore, kAppWithJIT, and kAppNoJIT. Remove
snapshot_code flag.
==========

to

==========
Split Snapshot::kFull into kCore, kAppWithJIT, and kAppNoJIT. Remove
snapshot_code flag.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f55c9c54a8821d9a421a64810e770beb491f754d
==========

[rmacnak, 2016-04-27 00:03:28]

Committed patchset #4 (id:60001) manually as
f55c9c54a8821d9a421a64810e770beb491f754d (presubmit successful).