third_party/WebKit/Source/web/WebViewImpl.h - Issue 1918183004: Switch the inheritance of WebView from WebWidget to protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 1918183004: Switch the inheritance of WebView from WebWidget to protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set webwidget on frame creation instead of view creation Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/shell/renderer/layout_test/layout_test_content_renderer_client.cc ('K') | « third_party/WebKit/Source/web/WebLocalFrameImpl.h ('k') | third_party/WebKit/public/web/WebLocalFrame.h » ('j') | third_party/WebKit/public/web/WebView.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebViewImpl.h

diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h

index 6c951efa8a18064d8102ae9893c6cd1ae9230519..43b6aec809d567efbdc589b1387c68d0ab85c324 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.h

+++ b/third_party/WebKit/Source/web/WebViewImpl.h

@@ -755,7 +755,6 @@ private:

double m_lastFrameTimeMonotonic;

};

-DEFINE_TYPE_CASTS(WebViewImpl, WebWidget, widget, widget->isWebView(), widget.isWebView());

// We have no ways to check if the specified WebView is an instance of

// WebViewImpl because WebViewImpl is the only implementation of WebView.

DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);