Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 1918183004: Switch the inheritance of WebView from WebWidget to protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: set webwidget on frame creation instead of view creation Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.h
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.h b/third_party/WebKit/Source/web/WebLocalFrameImpl.h
index 7e531182a4165f42128fc4f058a15f7b652a1417..150afc717418915eb2ed142a8ca0850b22f28249 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.h
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.h
@@ -35,6 +35,7 @@
#include "core/frame/LocalFrame.h"
#include "platform/geometry/FloatRect.h"
#include "public/platform/WebFileSystemType.h"
+#include "public/web/WebFrameWidget.h"
#include "public/web/WebLocalFrame.h"
#include "web/FrameLoaderClientImpl.h"
#include "web/UserMediaClientImpl.h"
@@ -59,7 +60,6 @@ class WebDataSourceImpl;
class WebDevToolsAgentImpl;
class WebDevToolsFrontendImpl;
class WebFrameClient;
-class WebFrameWidget;
class WebNode;
class WebPerformance;
class WebPlugin;
@@ -243,6 +243,7 @@ public:
void findMatchRects(WebVector<WebFloatRect>&) override;
int selectNearestFindMatch(const WebFloatPoint&, WebRect* selectionRect) override;
void setTickmarks(const WebVector<WebRect>&) override;
+ WebFrameWidget* frameWidget() const override;
// WebFrameImplBase methods:
void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name, const AtomicString& uniqueName) override;
@@ -320,7 +321,6 @@ public:
VisiblePosition visiblePositionForViewportPoint(const WebPoint&);
void setFrameWidget(WebFrameWidget*);
- WebFrameWidget* frameWidget() const;
// DevTools front-end bindings.
void setDevToolsFrontend(WebDevToolsFrontendImpl* frontend) { m_webDevToolsFrontend = frontend; }

Powered by Google App Engine
This is Rietveld 408576698