Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4401)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

Issue 1918053002: MD Settings: Search engines, use favicon cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Handle missing iconURL case. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
index fd02264bc12fec4f38132eb7a95914d22a6909d7..08be498d041f0c19005af70e3a76a270738f535a 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
@@ -71,4 +71,14 @@ Polymer({
closePopupMenu_: function() {
this.$$('iron-dropdown').close();
},
+
+ /**
+ * @param {?string} url The icon URL if available.
+ * @return {string} A set of icon URLs.
+ * @private
+ */
+ getIconSet_: function(url) {
+ // Force default icon, if no |engine.iconURL| is available.
+ return getFaviconImageSet(url || '');
+ },
});
« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698