chrome/browser/resources/settings/search_engines_page/search_engine_entry.html - Issue 1918053002: MD Settings: Search engines, use favicon cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

Issue 1918053002: MD Settings: Search engines, use favicon cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handle missing iconURL case. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.css ('k') | chrome/browser/resources/settings/search_engines_page/search_engine_entry.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

index 95d61f3c860ad729e3ee34cc43b8e2693136e59d..a08c8b1e42d3781ca2fc07b6d877f7e6eb650be9 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

@@ -1,11 +1,10 @@

-<link rel="import" href="chrome://md-settings/search_engines_page/search_engine_dialog.html">

-<link rel="import" href="chrome://md-settings/search_engines_page/search_engines_browser_proxy.html">

+<link rel="import" href="chrome://resources/html/util.html">

-<link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">

-<link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">

+<link rel="import" href="chrome://md-settings/search_engines_page/search_engine_dialog.html">

+<link rel="import" href="chrome://md-settings/search_engines_page/search_engines_browser_proxy.html">

<dom-module id="settings-search-engine-entry">

@@ -36,14 +35,8 @@

</template>

- <span class="icon-container">

- <template is="dom-if" if="[[engine.iconURL]]">

- <iron-icon src="[[engine.iconURL]]"></iron-icon>

- </template>

- <template is="dom-if" if="[[!engine.iconURL]]">

- <iron-icon icon="icons:find-in-page"></iron-icon>

- </template>

- </span>

+ <span class="favicon-image"

+ style="background-image: [[getIconSet_(engine.iconURL)]]"></span>

<span class="name">[[engine.displayName]]</span>

</div>

<div class="keyword-column">[[engine.keyword]]</div>