chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js - Issue 1918053002: MD Settings: Search engines, use favicon cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

Issue 1918053002: MD Settings: Search engines, use favicon cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handle missing iconURL case. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html ('k') | chrome/browser/resources/settings/search_engines_page/search_engine_entry.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

diff --git a/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js b/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

index 162ce84dac59b0ef96925acf6f3fbd1c17b2bea7..f02aeb386bb6373062489ae38d1c1f971482dae8 100644

--- a/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

+++ b/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

@@ -38,4 +38,13 @@ Polymer({

closePopupMenu_: function() {

this.$$('iron-dropdown').close();

+ /**

+ * @param {string} url

+ * @return {string} A set of icon URLs.

+ * @private

+ */

+ getIconSet_: function(url) {

+ return getFaviconImageSet(url);

+ },

});