Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html

Issue 1918053002: MD Settings: Search engines, use favicon cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Handle missing iconURL case. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
diff --git a/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html b/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
index 9615ec8f39f6712bdaa5af72b0aea71e4eacff3d..976591d48ddf6dd6ace189cc86f3a3d2135203f9 100644
--- a/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
+++ b/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
@@ -1,8 +1,7 @@
<link rel="import" href="chrome://resources/html/polymer.html">
+<link rel="import" href="chrome://resources/html/util.html">
<link rel="import" href="chrome://md-settings/search_engines_page/search_engines_browser_proxy.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-dropdown.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
<link rel="import" href="chrome://md-settings/settings_shared_css.html">
@@ -10,8 +9,7 @@
<dom-module id="settings-omnibox-extension-entry">
<link rel="import" type="css" href="chrome://md-settings/search_engines_page/search_engine_entry.css">
<template>
- <style include="settings-shared"></style>
- <style>
+ <style include="settings-shared">
.name-column {
flex: 3;
}
@@ -22,14 +20,8 @@
</style>
<div id="container" class="list-item">
<div class="name-column">
- <span class="icon-container">
- <template is="dom-if" if="[[engine.iconURL]]">
- <iron-icon src="[[engine.iconURL]]"></iron-icon>
- </template>
- <template is="dom-if" if="[[!engine.iconURL]]">
- <iron-icon icon="icons:find-in-page"></iron-icon>
- </template>
- </span>
+ <span class="favicon-image"
+ style="background-image: [[getIconSet_(engine.iconURL)]]"></span>
<span class="name">[[engine.displayName]]</span>
</div>
<div class="keyword-column">[[engine.keyword]]</div>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698