Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1917933003: Add missing method stub for _GerritCodereviewImpl. (Closed)

Created:
4 years, 8 months ago by tandrii(chromium)
Modified:
4 years, 8 months ago
Reviewers:
hinoka, scottmg
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing method stub for _GerritCodereviewImpl. This should make presubmit happy for oncoming git cl desc for Gerrit: https://codereview.chromium.org/1917473002/ BUG=603207 TBR=hinoka@chromium.org,scottmg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M git_cl.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tandrii(chromium)
4 years, 8 months ago (2016-04-26 10:55:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917933003/1
4 years, 8 months ago (2016-04-26 10:55:20 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 10:57:53 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300186

Powered by Google App Engine
This is Rietveld 408576698