Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2226)

Unified Diff: git_cl.py

Issue 1917933003: Add missing method stub for _GerritCodereviewImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 45dace5f295929b90dd63205860a0047b9a10e0e..49d11c1a2aa5cf5a61c626f7621c6078d538dc19 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -2175,6 +2175,13 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase):
def CloseIssue(self):
gerrit_util.AbandonChange(self._GetGerritHost(), self.GetIssue(), msg='')
+ def GetApprovingReviewers(self):
+ """Returns a list of reviewers approving the change.
+
+ Note: not necessarily committers.
+ """
+ raise NotImplementedError()
+
def SubmitIssue(self, wait_for_merge=True):
gerrit_util.SubmitChange(self._GetGerritHost(), self.GetIssue(),
wait_for_merge=wait_for_merge)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698