Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1917403002: Allow multiple host pseudos in same compound. (Closed)

Created:
4 years, 7 months ago by kochi
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Allow multiple host pseudos in same compound. As part of optimizing away :host(-context) selectors which never may match, we also skipped selectors with multiple :host(-context) pseudos in the same compound. Removed assert in findBestRuleSetAndAdd as that would now be required to traverse the whole compound again to cover everything. BUG=601585 Review URL: https://codereview.chromium.org/1872343002 Cr-Commit-Position: refs/heads/master@{#387263} (cherry picked from commit fd7037ec2f171b5f917f90ece37ba20b4d8506ce) Committed: https://chromium.googlesource.com/chromium/src/+/369818b67173d3ed4cbbc3af82fcb17a9a5528cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/shadow/multiple-host-pseudos-in-compound.html View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/shadow/multiple-host-pseudos-in-compound-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kochi
4 years, 7 months ago (2016-04-27 06:14:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
369818b67173d3ed4cbbc3af82fcb17a9a5528cf.

Powered by Google App Engine
This is Rietveld 408576698