Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1872343002: Allow multiple host pseudos in same compound. (Closed)

Created:
4 years, 8 months ago by rune
Modified:
4 years, 8 months ago
Reviewers:
Timothy Loh, esprehn
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow multiple host pseudos in same compound. As part of optimizing away :host(-context) selectors which never may match, we also skipped selectors with multiple :host(-context) pseudos in the same compound. Removed assert in findBestRuleSetAndAdd as that would now be required to traverse the whole compound again to cover everything. BUG=601585 Committed: https://crrev.com/fd7037ec2f171b5f917f90ece37ba20b4d8506ce Cr-Commit-Position: refs/heads/master@{#387263}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : More tests #

Patch Set 4 : ... and a test with :host() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/shadow/multiple-host-pseudos-in-compound.html View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/shadow/multiple-host-pseudos-in-compound-expected.txt View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872343002/1
4 years, 8 months ago (2016-04-11 12:42:18 UTC) #2
rune
ptal
4 years, 8 months ago (2016-04-11 12:43:10 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 15:02:33 UTC) #6
rune
4 years, 8 months ago (2016-04-13 16:10:34 UTC) #8
Timothy Loh
lgtm, but it'd be nice to test a few more combinations of :host/:host()/:host-context().
4 years, 8 months ago (2016-04-14 05:41:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872343002/60001
4 years, 8 months ago (2016-04-14 07:34:42 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-14 08:42:19 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 08:43:39 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fd7037ec2f171b5f917f90ece37ba20b4d8506ce
Cr-Commit-Position: refs/heads/master@{#387263}

Powered by Google App Engine
This is Rietveld 408576698