Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1917263002: Revert of depot_tools: add infra_paths recipe module for infra-specific paths (Closed)

Created:
4 years, 7 months ago by tandrii(chromium)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ ) Reason for revert: breaks skia bots :( Original issue's description: > depot_tools: add infra_paths recipe module for infra-specific paths > > Depends on https://codereview.chromium.org/1906323003 > > BUG=chromium:605919 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184 TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:605919 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300199

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -555 lines) Patch
M infra/config/recipes.cfg View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/bot_update/api.py View 2 chunks +3 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/basic.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/basic_output_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/basic_with_branch_heads.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/clobber.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/forced.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/gerrit_no_reset.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/no_shallow.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/off.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/reset_root_solution_revision.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/svn_mode.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/trychange.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/trychange_oauth2.json View 1 chunk +3 lines, -2 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch.json View 2 chunks +2 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json View 2 chunks +2 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_gerrit_angle.json View 2 chunks +2 lines, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_v8.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_v8_head_by_default.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/gclient/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/gclient/api.py View 4 chunks +6 lines, -10 lines 0 comments Download
M recipe_modules/gclient/example.py View 2 chunks +1 line, -2 lines 0 comments Download
M recipe_modules/gclient/example.expected/basic.json View 8 chunks +10 lines, -4 lines 0 comments Download
M recipe_modules/gclient/example.expected/revision.json View 8 chunks +10 lines, -4 lines 0 comments Download
M recipe_modules/gclient/example.expected/tryserver.json View 9 chunks +13 lines, -7 lines 0 comments Download
M recipe_modules/git/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/git/api.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.py View 3 chunks +2 lines, -3 lines 0 comments Download
M recipe_modules/git/example.expected/basic.json View 16 chunks +18 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/basic_branch.json View 16 chunks +18 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/basic_file_name.json View 16 chunks +18 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/basic_hash.json View 16 chunks +18 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/basic_ref.json View 16 chunks +18 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/basic_submodule_update_force.json View 16 chunks +18 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/can_fail_build.json View 13 chunks +14 lines, -13 lines 0 comments Download
M recipe_modules/git/example.expected/cannot_fail_build.json View 16 chunks +18 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/cat-file_test.json View 18 chunks +20 lines, -19 lines 0 comments Download
M recipe_modules/git/example.expected/count-objects_delta.json View 18 chunks +20 lines, -19 lines 0 comments Download
M recipe_modules/git/example.expected/count-objects_failed.json View 16 chunks +18 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/count-objects_with_bad_output.json View 16 chunks +18 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/count-objects_with_bad_output_fails_build.json View 8 chunks +9 lines, -8 lines 0 comments Download
M recipe_modules/git/example.expected/curl_trace_file.json View 16 chunks +19 lines, -18 lines 0 comments Download
M recipe_modules/git/example.expected/platform_win.json View 16 chunks +18 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/rebase_failed.json View 16 chunks +17 lines, -16 lines 0 comments Download
M recipe_modules/git/example.expected/remote_not_origin.json View 16 chunks +18 lines, -17 lines 0 comments Download
M recipe_modules/git/example.expected/set_got_revision.json View 16 chunks +18 lines, -17 lines 0 comments Download
D recipe_modules/infra_paths/__init__.py View 1 chunk +0 lines, -5 lines 0 comments Download
D recipe_modules/infra_paths/api.py View 1 chunk +0 lines, -33 lines 0 comments Download
D recipe_modules/infra_paths/config.py View 1 chunk +0 lines, -50 lines 0 comments Download
D recipe_modules/infra_paths/example.py View 1 chunk +0 lines, -24 lines 0 comments Download
D recipe_modules/infra_paths/example.expected/linux.json View 1 chunk +0 lines, -12 lines 0 comments Download
D recipe_modules/infra_paths/example.expected/linux_kitchen.json View 1 chunk +0 lines, -12 lines 0 comments Download
D recipe_modules/infra_paths/example.expected/mac.json View 1 chunk +0 lines, -12 lines 0 comments Download
D recipe_modules/infra_paths/example.expected/mac_kitchen.json View 1 chunk +0 lines, -12 lines 0 comments Download
D recipe_modules/infra_paths/example.expected/win.json View 1 chunk +0 lines, -12 lines 0 comments Download
D recipe_modules/infra_paths/example.expected/win_kitchen.json View 1 chunk +0 lines, -12 lines 0 comments Download
M recipe_modules/presubmit/example.expected/basic.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/rietveld/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/rietveld/api.py View 1 chunk +6 lines, -6 lines 0 comments Download
M recipe_modules/rietveld/example.py View 2 chunks +1 line, -2 lines 0 comments Download
M recipe_modules/rietveld/example.expected/basic.json View 2 chunks +5 lines, -4 lines 0 comments Download
M recipe_modules/tryserver/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/tryserver/api.py View 1 chunk +1 line, -2 lines 0 comments Download
M recipe_modules/tryserver/example.py View 2 chunks +1 line, -2 lines 0 comments Download
M recipe_modules/tryserver/example.expected/with_git_patch.json View 6 chunks +13 lines, -9 lines 0 comments Download
M recipe_modules/tryserver/example.expected/with_rietveld_patch.json View 4 chunks +5 lines, -3 lines 0 comments Download
M recipe_modules/tryserver/example.expected/with_svn_patch.json View 4 chunks +5 lines, -2 lines 0 comments Download
M recipe_modules/tryserver/example.expected/with_wrong_patch.json View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
tandrii(chromium)
Created Revert of depot_tools: add infra_paths recipe module for infra-specific paths
4 years, 7 months ago (2016-04-26 18:51:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917263002/1
4 years, 7 months ago (2016-04-26 18:51:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300199
4 years, 7 months ago (2016-04-26 18:51:59 UTC) #4
tandrii(chromium)
4 years, 7 months ago (2016-04-26 18:53:57 UTC) #5
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1921373002/ by tandrii@chromium.org.

The reason for reverting is: re-landing because wrong order of reverts :(.

Powered by Google App Engine
This is Rietveld 408576698