Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1917253006: Do not remove -webkit-appearance:meter by background or border CSS properties. (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not remove -webkit-appearance:meter by background or border CSS properties. Since crrev.com/390324, <meter> with -webkit-appearance:none doesn't show fancy widget. Existing pages might remove -webkit-appearance:meter by background/border unexpectedly. So we stop this behavior. BUG=51182 Committed: https://crrev.com/455ada0110b3246116a286ee292835a72f7be10b Cr-Commit-Position: refs/heads/master@{#390343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/HTMLMeterElement/meter-styles.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
tkent
Keishi, would you review this please?
4 years, 7 months ago (2016-04-28 08:31:27 UTC) #2
keishi
LGTM
4 years, 7 months ago (2016-04-28 09:16:04 UTC) #3
mstensho (USE GERRIT)
Typo: -webkit-appearnace
4 years, 7 months ago (2016-04-28 09:19:49 UTC) #5
mstensho (USE GERRIT)
On 2016/04/28 09:19:49, mstensho wrote: > Typo: -webkit-appearnace Oh... and "broder".
4 years, 7 months ago (2016-04-28 09:20:16 UTC) #6
tkent
On 2016/04/28 at 18:20:16, mstensho wrote: > On 2016/04/28 09:19:49, mstensho wrote: > > Typo: ...
4 years, 7 months ago (2016-04-28 09:36:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917253006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917253006/1
4 years, 7 months ago (2016-04-28 09:37:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 10:54:48 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:17:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/455ada0110b3246116a286ee292835a72f7be10b
Cr-Commit-Position: refs/heads/master@{#390343}

Powered by Google App Engine
This is Rietveld 408576698