Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTheme.cpp

Issue 1917253006: Do not remove -webkit-appearance:meter by background or border CSS properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/HTMLMeterElement/meter-styles.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * This file is part of the theme implementation for form controls in WebCore. 2 * This file is part of the theme implementation for form controls in WebCore.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc. 4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 379 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 return appearance != CheckboxPart && appearance != RadioPart; 390 return appearance != CheckboxPart && appearance != RadioPart;
391 } 391 }
392 392
393 bool LayoutTheme::isControlStyled(const ComputedStyle& style) const 393 bool LayoutTheme::isControlStyled(const ComputedStyle& style) const
394 { 394 {
395 switch (style.appearance()) { 395 switch (style.appearance()) {
396 case PushButtonPart: 396 case PushButtonPart:
397 case SquareButtonPart: 397 case SquareButtonPart:
398 case ButtonPart: 398 case ButtonPart:
399 case ProgressBarPart: 399 case ProgressBarPart:
400 case MeterPart:
401 return style.hasAuthorBackground() || style.hasAuthorBorder(); 400 return style.hasAuthorBackground() || style.hasAuthorBorder();
402 401
403 case MenulistPart: 402 case MenulistPart:
404 case SearchFieldPart: 403 case SearchFieldPart:
405 case TextAreaPart: 404 case TextAreaPart:
406 case TextFieldPart: 405 case TextFieldPart:
407 return style.hasAuthorBackground() || style.hasAuthorBorder() || style.b oxShadow(); 406 return style.hasAuthorBackground() || style.hasAuthorBorder() || style.b oxShadow();
408 407
409 default: 408 default:
410 return false; 409 return false;
(...skipping 507 matching lines...) Expand 10 before | Expand all | Expand 10 after
918 917
919 // padding - not honored by WinIE, needs to be removed. 918 // padding - not honored by WinIE, needs to be removed.
920 style.resetPadding(); 919 style.resetPadding();
921 920
922 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme) 921 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme)
923 // for now, we will not honor it. 922 // for now, we will not honor it.
924 style.resetBorder(); 923 style.resetBorder();
925 } 924 }
926 925
927 } // namespace blink 926 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/HTMLMeterElement/meter-styles.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698