Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 1917223006: Fix warnings that were exposed when running with SK_DEBUG enable on an optimized release build. (Closed)

Created:
4 years, 7 months ago by djsollen
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix warnings that were exposed when running with SK_DEBUG enable on an optimized release build. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917223006 Committed: https://skia.googlesource.com/skia/+/2f124631583a838edaa1e48362031cc6c7f40764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M gyp/common.gypi View 1 chunk +10 lines, -0 lines 0 comments Download
M src/animator/SkDrawBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPath.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (13 generated)
djsollen
4 years, 7 months ago (2016-04-28 14:33:21 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917223006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917223006/1
4 years, 7 months ago (2016-04-28 14:33:50 UTC) #5
djsollen
4 years, 7 months ago (2016-04-28 14:57:25 UTC) #7
caryclark
lgtm
4 years, 7 months ago (2016-04-28 14:59:04 UTC) #8
stephana
On 2016/04/28 14:57:25, djsollen wrote: lgtm
4 years, 7 months ago (2016-04-28 15:00:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917223006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917223006/1
4 years, 7 months ago (2016-04-28 15:10:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917223006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917223006/1
4 years, 7 months ago (2016-04-28 15:11:04 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917223006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917223006/1
4 years, 7 months ago (2016-04-29 18:10:38 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 20:53:09 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2f124631583a838edaa1e48362031cc6c7f40764

Powered by Google App Engine
This is Rietveld 408576698