Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: gyp/common.gypi

Issue 1917223006: Fix warnings that were exposed when running with SK_DEBUG enable on an optimized release build. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/animator/SkDrawBitmap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common.gypi
diff --git a/gyp/common.gypi b/gyp/common.gypi
index e0196cfd2af70c1d46d2fe8a10c4a92af0c63051..9ca2895d540316cf76e20ad96bd651785ac7e252 100644
--- a/gyp/common.gypi
+++ b/gyp/common.gypi
@@ -102,6 +102,16 @@
'Release_Developer': {
'inherit_from': ['Release'],
'defines': [ 'SK_DEBUG=1' ],
+ 'conditions': [
+ [ 'skia_clang_build == 0', {
+ # gcc has problems providing useful warnings of these types for
+ # optimized builds.
+ 'cflags': [
+ '-Wno-maybe-uninitialized',
+ '-Wno-strict-overflow',
+ ],
+ }],
+ ],
},
},
}],
« no previous file with comments | « no previous file | src/animator/SkDrawBitmap.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698