Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1917203002: Remove more type casts (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+536 lines, -567 lines) Patch
M pkg/analyzer/lib/source/embedder.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/context/cache.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 5 chunks +38 lines, -43 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/constant/utilities.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/dart/constant/value.dart View 4 chunks +46 lines, -49 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 9 chunks +87 lines, -69 lines 2 comments Download
M pkg/analyzer/lib/src/dart/element/type.dart View 4 chunks +30 lines, -33 lines 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart View 3 chunks +10 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 7 chunks +31 lines, -39 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +23 lines, -24 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 11 chunks +187 lines, -198 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 6 chunks +62 lines, -77 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 2 chunks +4 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 8 months ago (2016-04-26 15:40:58 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1917203002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/1917203002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode466 pkg/analyzer/lib/src/dart/element/element.dart:466: PropertyAccessorElementImpl accessorImpl = accessor; Is this implicit cast ...
4 years, 8 months ago (2016-04-26 16:05:29 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1917203002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/1917203002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode466 pkg/analyzer/lib/src/dart/element/element.dart:466: PropertyAccessorElementImpl accessorImpl = accessor; > Is this implicit cast ...
4 years, 8 months ago (2016-04-26 17:09:59 UTC) #4
Brian Wilkerson
4 years, 8 months ago (2016-04-26 17:11:01 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7ca7c9d9e6c3324286285c73a3898243f8e75886 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698