Remove more type casts

pkg/analyzer/lib/src/dart/constant/value.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * The implementation of the class [DartObject].
  */
 library analyzer.src.dart.constant.value;
 
 import 'dart:collection';
@@ skipping 196 matching lines @@
   bool get isUnknown => _state.isUnknown;
 
   /**
    * Return `true` if this object represents an instance of a user-defined
    * class.
    */
   bool get isUserDefinedObject => _state is GenericState;
 
   @override
   bool operator ==(Object object) {
-    if (object is! DartObjectImpl) {
-      return false;
+    if (object is DartObjectImpl) {
+      return type == object.type && _state == object._state;
     }
-    DartObjectImpl dartObject = object as DartObjectImpl;
-    return type == dartObject.type && _state == dartObject._state;
+    return false;
   }
 
   /**
    * Return the result of invoking the '+' operator on this object with the
    * given [rightOperand]. The [typeProvider] is the type provider used to find
    * known types.
    *
    * Throws an [EvaluationException] if the operator is not appropriate for an
    * object of this kind.
    */
@@ skipping 1116 matching lines @@
   }
 
   @override
   bool get isUnknown => identical(this, UNKNOWN_VALUE);
 
   @override
   String get typeName => "user defined type";
 
   @override
   bool operator ==(Object object) {
-    if (object is! GenericState) {
-      return false;
+    if (object is GenericState) {
+      HashSet<String> otherFields =
+          new HashSet<String>.from(object._fieldMap.keys.toSet());
+      for (String fieldName in _fieldMap.keys.toSet()) {
+        if (_fieldMap[fieldName] != object._fieldMap[fieldName]) {
+          return false;
+        }
+        otherFields.remove(fieldName);
+      }
+      for (String fieldName in otherFields) {
+        if (object._fieldMap[fieldName] != _fieldMap[fieldName]) {
+          return false;
+        }
+      }
+      return true;
     }
-    GenericState state = object as GenericState;
-    HashSet<String> otherFields =
-        new HashSet<String>.from(state._fieldMap.keys.toSet());
-    for (String fieldName in _fieldMap.keys.toSet()) {
-      if (_fieldMap[fieldName] != state._fieldMap[fieldName]) {
-        return false;
-      }
-      otherFields.remove(fieldName);
-    }
-    for (String fieldName in otherFields) {
-      if (state._fieldMap[fieldName] != _fieldMap[fieldName]) {
-        return false;
-      }
-    }
-    return true;
+    return false;
   }
 
   @override
   StringState convertToString() => StringState.UNKNOWN_VALUE;
 
   @override
   BoolState equalEqual(InstanceState rightOperand) {
     assertBoolNumStringOrNull(rightOperand);
     return isIdentical(rightOperand);
   }
@@ skipping 915 matching lines @@
       value = (value << 3) ^ _elements[i].hashCode;
     }
     return value;
   }
 
   @override
   String get typeName => "List";
 
   @override
   bool operator ==(Object object) {
-    if (object is! ListState) {
-      return false;
-    }
-    List<DartObjectImpl> otherElements = (object as ListState)._elements;
-    int count = _elements.length;
-    if (otherElements.length != count) {
-      return false;
-    } else if (count == 0) {
+    if (object is ListState) {
+      List<DartObjectImpl> otherElements = object._elements;
+      int count = _elements.length;
+      if (otherElements.length != count) {
+        return false;
+      } else if (count == 0) {
+        return true;
+      }
+      for (int i = 0; i < count; i++) {
+        if (_elements[i] != otherElements[i]) {
+          return false;
+        }
+      }
       return true;
     }
-    for (int i = 0; i < count; i++) {
-      if (_elements[i] != otherElements[i]) {
-        return false;
-      }
-    }
-    return true;
+    return false;
   }
 
   @override
   StringState convertToString() => StringState.UNKNOWN_VALUE;
 
   @override
   BoolState equalEqual(InstanceState rightOperand) {
     assertBoolNumStringOrNull(rightOperand);
     return isIdentical(rightOperand);
   }
@@ skipping 46 matching lines @@
       value = (value << 3) ^ key.hashCode;
     }
     return value;
   }
 
   @override
   String get typeName => "Map";
 
   @override
   bool operator ==(Object object) {
-    if (object is! MapState) {
-      return false;
-    }
-    HashMap<DartObjectImpl, DartObjectImpl> otherElements =
-        (object as MapState)._entries;
-    int count = _entries.length;
-    if (otherElements.length != count) {
-      return false;
-    } else if (count == 0) {
+    if (object is MapState) {
+      HashMap<DartObjectImpl, DartObjectImpl> otherElements = object._entries;
+      int count = _entries.length;
+      if (otherElements.length != count) {
+        return false;
+      } else if (count == 0) {
+        return true;
+      }
+      for (DartObjectImpl key in _entries.keys) {
+        DartObjectImpl value = _entries[key];
+        DartObjectImpl otherValue = otherElements[key];
+        if (value != otherValue) {
+          return false;
+        }
+      }
       return true;
     }
-    for (DartObjectImpl key in _entries.keys) {
-      DartObjectImpl value = _entries[key];
-      DartObjectImpl otherValue = otherElements[key];
-      if (value != otherValue) {
-        return false;
-      }
-    }
-    return true;
+    return false;
   }
 
   @override
   StringState convertToString() => StringState.UNKNOWN_VALUE;
 
   @override
   BoolState equalEqual(InstanceState rightOperand) {
     assertBoolNumStringOrNull(rightOperand);
     return isIdentical(rightOperand);
   }
@@ skipping 396 matching lines @@
       return BoolState.from(_element == rightElement);
     } else if (rightOperand is DynamicState) {
       return BoolState.UNKNOWN_VALUE;
     }
     return BoolState.FALSE_STATE;
   }
 
   @override
   String toString() => _element == null ? "-unknown-" : _element.name;
 }