Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1917193003: Revert of 🍈 Unify application context usage. (Closed)

Created:
4 years, 7 months ago by Peter Wen
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 🍈 Unify application context usage. (patchset #25 id:480001 of https://codereview.chromium.org/1879013002/ ) Reason for revert: Broke CQ unittests as they did not set native application context properly. See https://codereview.chromium.org/1919283002/ for context. Original issue's description: > Unify application context usage. > > Separate out ContextUtils initializing the global application context > on java-side vs native-side. Have LibraryLoader initialize > native-side application side and initialize java-side application > context as early as possible. > > This allows callers to be certain that they are interacting with the > application context instead of a local context, and will allow > consolidating application-wide context-based globals like > SharedPreferences in subsequent CLs. > > BUG=552419 > > Committed: https://crrev.com/6b5b7b5d2a1d2cdfa58e8e06f9a350ea4d1b286a > Cr-Commit-Position: refs/heads/master@{#389782} TBR=torne@chromium.org,davidben@chromium.org,yfriedman@chromium.org,nyquist@chromium.org,caitkp@chromium.org,sergeyu@chromium.org,amistry@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=552419 Committed: https://crrev.com/db5dfaca02607f6013ed58bad136b98c5543f2cd Cr-Commit-Position: refs/heads/master@{#389820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -89 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 7 chunks +19 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java View 4 chunks +5 lines, -9 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java View 2 chunks +2 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/test/AwTestRunnerActivity.java View 2 chunks +0 lines, -2 lines 0 comments Download
M base/android/context_utils.h View 1 chunk +8 lines, -0 lines 0 comments Download
M base/android/context_utils.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/ContextUtils.java View 3 chunks +18 lines, -36 lines 0 comments Download
M base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java View 4 chunks +11 lines, -8 lines 0 comments Download
M blimp/client/app/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 2 chunks +0 lines, -3 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java View 2 chunks +1 line, -2 lines 0 comments Download
M components/resource_provider/android/android_hooks.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/resource_provider/android/java/org/chromium/resource_provider/Main.java View 2 chunks +0 lines, -2 lines 0 comments Download
M components/web_restrictions/browser/junit/src/org/chromium/components/webrestrictions/WebRestrictionsClientTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ChildProcessService.java View 2 chunks +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java View 3 chunks +4 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java View 1 chunk +1 line, -1 line 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/MojoTestCase.java View 2 chunks +3 lines, -4 lines 0 comments Download
M net/android/junit/src/org/chromium/net/HttpNegotiateAuthenticatorTest.java View 1 chunk +1 line, -1 line 0 comments Download
M remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java View 1 chunk +1 line, -1 line 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java View 1 chunk +2 lines, -1 line 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestActivity.java View 2 chunks +0 lines, -2 lines 0 comments Download
M testing/android/native_test/native_test_launcher.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Wen
Created Revert of 🍈 Unify application context usage.
4 years, 7 months ago (2016-04-26 18:17:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917193003/1
4 years, 7 months ago (2016-04-26 18:18:02 UTC) #2
jbudorick
lgtm
4 years, 7 months ago (2016-04-26 18:18:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-26 18:18:55 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 18:20:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db5dfaca02607f6013ed58bad136b98c5543f2cd
Cr-Commit-Position: refs/heads/master@{#389820}

Powered by Google App Engine
This is Rietveld 408576698