Created Revert of 🍈 Unify application context usage.
4 years, 7 months ago
(2016-04-26 18:17:33 UTC)
#1
Created Revert of 🍈 Unify application context usage.
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917193003/1
4 years, 7 months ago
(2016-04-26 18:18:02 UTC)
#2
4 years, 7 months ago
(2016-04-26 18:18:11 UTC)
#4
lgtm
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago
(2016-04-26 18:18:55 UTC)
#5
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== Revert of 🍈 Unify application context usage. (patchset #25 id:480001 ...
4 years, 7 months ago
(2016-04-26 18:20:29 UTC)
#6
Message was sent while issue was closed.
Description was changed from
==========
Revert of 🍈 Unify application context usage. (patchset #25 id:480001 of
https://codereview.chromium.org/1879013002/ )
Reason for revert:
Broke CQ unittests as they did not set native application context properly. See
https://codereview.chromium.org/1919283002/ for context.
Original issue's description:
> Unify application context usage.
>
> Separate out ContextUtils initializing the global application context
> on java-side vs native-side. Have LibraryLoader initialize
> native-side application side and initialize java-side application
> context as early as possible.
>
> This allows callers to be certain that they are interacting with the
> application context instead of a local context, and will allow
> consolidating application-wide context-based globals like
> SharedPreferences in subsequent CLs.
>
> BUG=552419
>
> Committed: https://crrev.com/6b5b7b5d2a1d2cdfa58e8e06f9a350ea4d1b286a
> Cr-Commit-Position: refs/heads/master@{#389782}
TBR=torne@chromium.org,davidben@chromium.org,yfriedman@chromium.org,nyquist@c...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=552419
==========
to
==========
Revert of 🍈 Unify application context usage. (patchset #25 id:480001 of
https://codereview.chromium.org/1879013002/ )
Reason for revert:
Broke CQ unittests as they did not set native application context properly. See
https://codereview.chromium.org/1919283002/ for context.
Original issue's description:
> Unify application context usage.
>
> Separate out ContextUtils initializing the global application context
> on java-side vs native-side. Have LibraryLoader initialize
> native-side application side and initialize java-side application
> context as early as possible.
>
> This allows callers to be certain that they are interacting with the
> application context instead of a local context, and will allow
> consolidating application-wide context-based globals like
> SharedPreferences in subsequent CLs.
>
> BUG=552419
>
> Committed: https://crrev.com/6b5b7b5d2a1d2cdfa58e8e06f9a350ea4d1b286a
> Cr-Commit-Position: refs/heads/master@{#389782}
TBR=torne@chromium.org,davidben@chromium.org,yfriedman@chromium.org,nyquist@c...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=552419
Committed: https://crrev.com/db5dfaca02607f6013ed58bad136b98c5543f2cd
Cr-Commit-Position: refs/heads/master@{#389820}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/db5dfaca02607f6013ed58bad136b98c5543f2cd Cr-Commit-Position: refs/heads/master@{#389820}
4 years, 7 months ago
(2016-04-26 18:20:30 UTC)
#7
Issue 1917193003: Revert of 🍈 Unify application context usage.
(Closed)
Created 4 years, 7 months ago by Peter Wen
Modified 4 years, 7 months ago
Reviewers: Torne, davidben, Yaron, nyquist, Cait (Slow), Sergey Ulanov, Anand Mistry (off Chromium), sky, jbudorick
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0