Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java

Issue 1917193003: Revert of 🍈 Unify application context usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
diff --git a/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java b/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
index 785827178d91ce0b27a2b36cb6fb4515ba1d66ca..6665ddfde738544d38fa382a7d0a9da91ede98d0 100644
--- a/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
+++ b/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
@@ -13,7 +13,6 @@
import android.os.SystemClock;
import org.chromium.base.CommandLine;
-import org.chromium.base.ContextUtils;
import org.chromium.base.Log;
import org.chromium.base.PackageUtils;
import org.chromium.base.TraceEvent;
@@ -133,8 +132,6 @@
* @param context The context in which the method is called.
*/
public void ensureInitialized(Context context) throws ProcessInitException {
- // TODO(wnwen): Move this call appropriately down to the tests that need it.
- ContextUtils.initApplicationContext(context.getApplicationContext());
synchronized (sLock) {
if (mInitialized) {
// Already initialized, nothing to do.
@@ -363,10 +360,6 @@
nativeInitCommandLine(CommandLine.getJavaSwitchesOrNull());
CommandLine.enableNativeProxy();
mCommandLineSwitched = true;
-
- // Ensure that native side application context is loaded and in sync with java side. Must do
- // this here so webview also gets its application context set before fully initializing.
- ContextUtils.initApplicationContextForNative();
}
// Invoke base::android::LibraryLoaded in library_loader_hooks.cc
@@ -375,11 +368,21 @@
return;
}
- ensureCommandLineSwitchedAlreadyLocked();
+ // Setup the native command line if necessary.
+ if (!mCommandLineSwitched) {
+ nativeInitCommandLine(CommandLine.getJavaSwitchesOrNull());
+ }
if (!nativeLibraryLoaded()) {
Log.e(TAG, "error calling nativeLibraryLoaded");
throw new ProcessInitException(LoaderErrors.LOADER_ERROR_FAILED_TO_REGISTER_JNI);
+ }
+
+ // The Chrome JNI is registered by now so we can switch the Java
+ // command line over to delegating to native if it's necessary.
+ if (!mCommandLineSwitched) {
+ CommandLine.enableNativeProxy();
+ mCommandLineSwitched = true;
}
// From now on, keep tracing in sync with native.

Powered by Google App Engine
This is Rietveld 408576698