Use a different string and icon for chrome-extension pages in Page Info Bubble.

Use a different string and icon for chrome-extension pages in Page Info Bubble.

Current bubble says "You are viewing a secure Chrome page", change it to "You are viewing an extension page". We should probably just show the full page info bubble here rather than the simplified one so that the user can change content settings for extensions, but some settings (e.g. images, javascript etc) don't work well with extensions so we are patching this for now.

BUG=567684
Committed: https://crrev.com/debec2e308461caa49aeeca7b53460b8c723840b
Cr-Commit-Position: refs/heads/master@{#390117}

[meacer, 2016-04-25 23:19:34]

Description was changed from

==========
Use a different string for chrome-extension pages in Page Info Bubble.

BUG=567684
==========

to

==========
Use a different string for chrome-extension pages in Page Info Bubble.

Current bubble says "You are viewing a secure Chrome page", change it to "You
are viewing an extension page".

BUG=567684
==========

[meacer, 2016-04-25 23:25:30]

Description was changed from

==========
Use a different string for chrome-extension pages in Page Info Bubble.

Current bubble says "You are viewing a secure Chrome page", change it to "You
are viewing an extension page".

BUG=567684
==========

to

==========
Use a different string for chrome-extension pages in Page Info Bubble.

Current bubble says "You are viewing a secure Chrome page", change it to "You
are viewing an extension page". We should probably just show the full page info
bubble here rather than the simplified one so that the user can change content
settings for extensions, but some settings (e.g. images, javascript etc) don't
work well with extensions so we are patching this for now.

BUG=567684
==========

[meacer, 2016-04-25 23:25:30]

meacer@chromium.org changed reviewers:
+ palmer@chromium.org

[palmer, 2016-04-26 22:43:45]

LGTM % nit

https://codereview.chromium.org/1917013002/diff/40001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
(right):

https://codereview.chromium.org/1917013002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm:1124:
if (url.SchemeIs("chrome"))
Nit: Better to use the kFooScheme constants?

[meacer, 2016-04-26 23:01:17]

https://codereview.chromium.org/1917013002/diff/40001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
(right):

https://codereview.chromium.org/1917013002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm:1124:
if (url.SchemeIs("chrome"))
On 2016/04/26 22:43:45, palmer wrote:
> Nit: Better to use the kFooScheme constants?

Done.

[meacer, 2016-04-26 23:01:32]

Description was changed from

==========
Use a different string for chrome-extension pages in Page Info Bubble.

Current bubble says "You are viewing a secure Chrome page", change it to "You
are viewing an extension page". We should probably just show the full page info
bubble here rather than the simplified one so that the user can change content
settings for extensions, but some settings (e.g. images, javascript etc) don't
work well with extensions so we are patching this for now.

BUG=567684
==========

to

==========
Use a different string and icon for chrome-extension pages in Page Info Bubble.

Current bubble says "You are viewing a secure Chrome page", change it to "You
are viewing an extension page". We should probably just show the full page info
bubble here rather than the simplified one so that the user can change content
settings for extensions, but some settings (e.g. images, javascript etc) don't
work well with extensions so we are patching this for now.

BUG=567684
==========

[meacer, 2016-04-26 23:03:07]

meacer@chromium.org changed reviewers:
+ sdefresne@chromium.org

[meacer, 2016-04-26 23:03:07]

sdefresne: Can you PTAL at pageinfo_strings.grdp? Thanks.

[sdefresne, 2016-04-27 08:40:21]

components/pageinfo_strings.grdp lgtm

[meacer, 2016-04-27 17:12:42]

The CQ bit was checked by meacer@chromium.org

[meacer, 2016-04-27 17:12:43]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org
Link to the patchset: https://codereview.chromium.org/1917013002/#ps80001
(title: "fix build")

[commit-bot: I haz the power, 2016-04-27 17:13:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917013002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917013002/80001

[commit-bot: I haz the power, 2016-04-27 17:47:31]

Description was changed from

==========
Use a different string and icon for chrome-extension pages in Page Info Bubble.

Current bubble says "You are viewing a secure Chrome page", change it to "You
are viewing an extension page". We should probably just show the full page info
bubble here rather than the simplified one so that the user can change content
settings for extensions, but some settings (e.g. images, javascript etc) don't
work well with extensions so we are patching this for now.

BUG=567684
==========

to

==========
Use a different string and icon for chrome-extension pages in Page Info Bubble.

Current bubble says "You are viewing a secure Chrome page", change it to "You
are viewing an extension page". We should probably just show the full page info
bubble here rather than the simplified one so that the user can change content
settings for extensions, but some settings (e.g. images, javascript etc) don't
work well with extensions so we are patching this for now.

BUG=567684
==========

[commit-bot: I haz the power, 2016-04-27 17:47:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-30 17:11:00]

Patchset 5 (id:??) landed as
https://crrev.com/debec2e308461caa49aeeca7b53460b8c723840b
Cr-Commit-Position: refs/heads/master@{#390117}

[commit-bot: I haz the power, 2016-04-30 17:50:40]

Description was changed from

==========
Use a different string and icon for chrome-extension pages in Page Info Bubble.

Current bubble says "You are viewing a secure Chrome page", change it to "You
are viewing an extension page". We should probably just show the full page info
bubble here rather than the simplified one so that the user can change content
settings for extensions, but some settings (e.g. images, javascript etc) don't
work well with extensions so we are patching this for now.

BUG=567684
==========

to

==========
Use a different string and icon for chrome-extension pages in Page Info Bubble.

Current bubble says "You are viewing a secure Chrome page", change it to "You
are viewing an extension page". We should probably just show the full page info
bubble here rather than the simplified one so that the user can change content
settings for extensions, but some settings (e.g. images, javascript etc) don't
work well with extensions so we are patching this for now.

BUG=567684

Committed: https://crrev.com/debec2e308461caa49aeeca7b53460b8c723840b
Cr-Commit-Position: refs/heads/master@{#390117}
==========