Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1681)

Unified Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h

Issue 1917013002: Use a different string and icon for chrome-extension pages in Page Info Bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix build Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h
index 5559c85751713adf3b6da1680c525b8d2417b963..69a1a99846ffaaf468f80bb2fac6773f58a1f807 100644
--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h
@@ -81,13 +81,19 @@ class WebContents;
std::unique_ptr<WebsiteSettingsUIBridge> bridge_;
}
+enum BubbleType {
+ WEB_PAGE, // Bubble for web URLs
+ INTERNAL_PAGE, // For chrome: URLs
+ EXTENSION_PAGE, // For chrome-extension: URLs
+};
+
// Designated initializer. The controller will release itself when the bubble
// is closed. |parentWindow| cannot be nil. |webContents| may be nil for
// testing purposes.
- (id)initWithParentWindow:(NSWindow*)parentWindow
websiteSettingsUIBridge:(WebsiteSettingsUIBridge*)bridge
webContents:(content::WebContents*)webContents
- isInternalPage:(BOOL)isInternalPage
+ bubbleType:(BubbleType)bubbleType
isDevToolsDisabled:(BOOL)isDevToolsDisabled;
// Return the default width of the window. It may be wider to fit the content.

Powered by Google App Engine
This is Rietveld 408576698