Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1916913008: This patch uses the WebContents' opener to extract the previous committed url for the very first na… (Closed)

Created:
4 years, 7 months ago by Charlie Harrison
Modified:
4 years, 7 months ago
Reviewers:
Bryan McQuade
CC:
chromium-reviews, csharrison+watch_chromium.org, asvitkine+watch_chromium.org, loading-reviews+metrics_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

This patch uses the WebContents' opener to extract the previous committed url for the very first navigation within the MetricsWebContentsObserver. This is used for the FromGWS abort metrics. This patch was split from the previous CL here: https://codereview.chromium.org/1901303004/ BUG=605259 Review URL: https://codereview.chromium.org/1924543002 Cr-Commit-Position: refs/heads/master@{#389893} (cherry picked from commit ff3dd0217b152227db56a7d0731b431873ce88eb) Add FromGWS variants to the AbortTiming metrics This patch was split off from the larger CL authored here: https://codereview.chromium.org/1901303004/ BUG=605259 Review URL: https://codereview.chromium.org/1919193003 Cr-Commit-Position: refs/heads/master@{#389903} (cherry picked from commit 6bd4ae311136de4f95b19b8f1a3e6d4d8430b560) TBR=bmcquade@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/b0b63747d1888fb9ea8b46d7bd5870b410200684

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Charlie Harrison
4 years, 7 months ago (2016-04-28 17:18:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b0b63747d1888fb9ea8b46d7bd5870b410200684 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698